Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removes old workflows and LXD packages #54

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

SecondSkoll
Copy link
Collaborator

@SecondSkoll SecondSkoll commented Mar 14, 2025

No longer publishing this as an LXD-images package, LXD should have transitioned away by now
Removes old and non-functional workflows
Removes lxd-sphinx-extensions content
Changes author to me - I'm not bothered if this should be someone else, but Ruth is no longer here and I'm probably the most active TA in this repo...

Copy link
Contributor

@tang-mm tang-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still multiple projects using this old name in their requirements file. I'm afraid removing this transitional setup.py will cause their dependency install to fail, and they won't see the message that the package has been renamed.

Since the package is already marked as inactive on pypi, the maintenance effort left is minimal, I think they should be kept in place

@SecondSkoll
Copy link
Collaborator Author

There are still multiple projects using this old name in their requirements file. I'm afraid removing this transitional setup.py will cause their dependency install to fail, and they won't see the message that the package has been renamed.

Since the package is already marked as inactive on pypi, the maintenance effort left is minimal, I think they should be kept in place

0.0.16 is on pypi and is just an empty package that installs canonical-sphinx-extensions. There's no maintenance needed for this package, and even if we wanted to release a new version we can't - as we don't have creds for it on pypi.

Should workflows break from repos using this old package, they can see on pypi that it's been renamed. The setup file is contained in the package, so there's no need for it to be retained - and on the off chance it is there's the Git history.

Copy link
Contributor

@tang-mm tang-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got your point about the published package! so +1

@tang-mm tang-mm merged commit 62b39c7 into canonical:main Mar 21, 2025
1 check passed
@SecondSkoll
Copy link
Collaborator Author

Sorry if I overexplain things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants