Add ubuntu-images extension #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And is too dumb to deal with data associated with a class being closely spaced next to the class
pylint picked this up ... flake8 didn't
|
flake8's still complaining about line-lengths, but most of these are either:
Personally I'd recommend just disabling the E501 test (or weakening it considerably). Actually I'd recommend switching the test to pylint (which tends to pick up more useful stuff and has much more descriptive and flexible disable comments), but that would probably be more painful. |
Always represent the range (even a degenerate singleton range) as a tuple instead of having branches for singletons and multi-item ranges
Some complaints about unused variable names (personally I think it's better to indicate what elements we're decoding but ignored, but whatever), and "f" for a float is fine, but "n" for a number is not. Apparently.
To be clear: this doesn't improve quality. In several cases it makes the code objectively worse, and weakens one test to the point it's no longer testing all it should. But "computer says no" otherwise...
We don't actually use it here (unlike in the rpi-imager refresh script that this class was copied from), and this brings us back within pylint's recommended maximum number of local vars in get_images
handle_data may be called multiple times for CDATA within an element. Admittedly this is incredibly unlikely for the input, but it's still the correct thing to do here.
Signed-off-by: Michael Park <[email protected]>
SecondSkoll
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from the ubuntu-boards-documentation. Tests included as doctest. To run, from a venv with the extensions installed:
Being doctest, no output and zero exit code means tests have passed. If you have coverage installed:
P.S. Please let me split up the README on the front of the repo :)