Update dependencies to mbedtls 4.0 and tinycbor 7.0#137
Merged
Harry-Chen merged 4 commits intodevfrom Mar 12, 2026
Merged
Conversation
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
…isting tinycbor 7.0 provides its own CMakeLists.txt with generate_export_header and configure_file for version/export headers. Switch from manually listing tinycbor source files to add_subdirectory + target_link_libraries. Options set: static lib, no floating-point, no tools/tests/examples.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build to consume tinycbor via its CMake subdirectory (instead of compiling its sources directly) and bumps the canokey-crypto/tinycbor submodules to newer commits aligned with mbedtls 4.0 + tinycbor 7.0.
Changes:
- Add
tinycboras a CMake subdirectory with freestanding/static configuration, and link it intocanokey-core. - Remove direct compilation and include-path references to
tinycbor/srcfrom the top-level build. - Update
canokey-cryptoandtinycborsubmodule SHAs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
CMakeLists.txt |
Builds tinycbor as a subproject and links it to canokey-core, removing direct source/include references. |
tinycbor |
Updates the tinycbor submodule commit pointer. |
canokey-crypto |
Updates the canokey-crypto submodule commit pointer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build system to use
tinycboras an external submodule and removes direct source file references. It also updates thecanokey-cryptoandtinycborsubmodules to newer commits. The most important changes are grouped below:Build system changes:
tinycboras an external submodule inCMakeLists.txt, enabling freestanding mode and disabling shared libraries. ([CMakeLists.txtR37-R41](https://github.com/canokeys/canokey-core/pull/137/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR37-R41))tinycborsource files from theSRCvariable and from the include directories inCMakeLists.txt, relying on the submodule build instead. ([[1]](https://github.com/canokeys/canokey-core/pull/137/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL48-L49),[[2]](https://github.com/canokeys/canokey-core/pull/137/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL70-R80))tinycboras a library dependency tocanokey-coreinCMakeLists.txt. ([CMakeLists.txtL70-R80](https://github.com/canokeys/canokey-core/pull/137/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL70-R80))Submodule updates:
canokey-cryptosubmodule to commit2217732a29d750400778900d17adf8aa6dd77bda. ([canokey-cryptoL1-R1](https://github.com/canokeys/canokey-core/pull/137/files#diff-b3ff5eea6e5ba1bb9bb5256b9fae5c2172f9b792d550f872b6cb58fd73d60f53L1-R1))tinycborsubmodule to commit6442e749ca811e24afad1551338a45c75e09808f. ([tinycborL1-R1](https://github.com/canokeys/canokey-core/pull/137/files#diff-89bad368485210ab514b6f6caa2f8d6625b75bae95fc000c9ae7d6b4c58f36d5L1-R1))