ENT-5542: Build package using GitHub Actions#3211
Merged
Conversation
Contributor
m-horky
commented
Feb 16, 2023
m-horky
commented
- Card ID: ENT-5542
cnsnyder
requested review from
a team and
jirihnidek
and removed request for
a team
Coverage (computed on Fedora latest) •
|
ptoscano
suggested changes
Feb 16, 2023
Contributor
ptoscano
left a comment
ptoscano
left a comment
There was a problem hiding this comment.
Good start! There are a couple of things that IMHO can be simplified.
m-horky
force-pushed
the
mhorky/ENT-5542_tito
branch
from
3869622 to
ec6afd0
Compare
* Card ID: ENT-5542
m-horky
force-pushed
the
mhorky/ENT-5542_tito
branch
from
ec6afd0 to
2791a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.