ENT-5541: Publish PR coverage#3200
Merged
jirihnidek merged 1 commit intocandlepin:mainfrom Feb 2, 2023
Merged
Conversation
m-horky
force-pushed
the
mhorky/5541_coverage
branch
12 times, most recently
from
331e0a9 to
f889f16
Compare
ptoscano
suggested changes
Feb 2, 2023
* Card ID: ENT-5541 Publish coverage report as a comment under the PR. - To send the comment only once, not for every matrix system, only 'Fedora latest' is used as a data source. - Because of how GitHub permissions work, the comment is only sent if the PR originates from a feature branch; nothing will be sent for a PR originating from some fork. Full coverage is still displayed in CI output, it is just not sent as a comment. - Package 'pytest-cov' is used instead of 'coverage'. It is still using coverage in a background, but it runs it as a pytest addon instead, allowing us to pass its arguments into pytest, instead of wrapping whole pytest call inside of a coverage invocation.
m-horky
force-pushed
the
mhorky/5541_coverage
branch
from
f889f16 to
ea495a6
Compare
ptoscano
approved these changes
Feb 2, 2023
Contributor
ptoscano
left a comment
ptoscano
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I'll leave it to @jirihnidek for an additional review, as I know he uses/checks the coverage details often when working on sub-man.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish coverage report as a comment under the PR.
'Fedora latest' is used as a data source.
the PR originates from a feature branch; nothing will be sent for a PR
originating from some fork. Full coverage is still displayed in CI
output, it is just not sent as a comment.
coverage in a background, but it runs it as a pytest addon instead,
allowing us to pass its arguments into pytest, instead of wrapping
whole pytest call inside of a coverage invocation.