[1.28] Fix failures of D-Bus' Register tests#3174
Merged
ptoscano merged 2 commits intosubscription-manager-1.28from Dec 5, 2022
Merged
[1.28] Fix failures of D-Bus' Register tests#3174ptoscano merged 2 commits intosubscription-manager-1.28from
ptoscano merged 2 commits intosubscription-manager-1.28from
Conversation
Cherry-picked from f636251
Our test that checks if it is possible to connect to newly created socket started failing with 'Permission denied' when the code tried to use it. Pytest cannot write into '/run', moving it to '/tmp' solves the issue. Additionally, as a result of relatively recent D-Bus implementation changes, 'tmpdir' and 'dir' behave the same and create regular socket, not an abstract socket. Connecting with "\0" prefix (which signifies the abstract one) now fails and thus has been removed from the tests. Cherry-picked from bae7ce3
m-horky
force-pushed
the
mhorky/1.28_dbus-register-tests
branch
from
08eb140 to
23248d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial backport of #3156