Skip to content

2118486: [1.28] Implement "force" register option in rhsm dbus python binding#3161

Merged
ptoscano merged 1 commit intosubscription-manager-1.28from
jajerome/ENT-5350-backport
Nov 22, 2022
Merged

2118486: [1.28] Implement "force" register option in rhsm dbus python binding#3161
ptoscano merged 1 commit intosubscription-manager-1.28from
jajerome/ENT-5350-backport

Conversation

@DuckBoss
Copy link
Contributor

@DuckBoss DuckBoss commented Nov 1, 2022

@DuckBoss DuckBoss force-pushed the jajerome/ENT-5350-backport branch 4 times, most recently from eb42fd8 to 3538cd3 Compare November 3, 2022 13:57
@DuckBoss DuckBoss force-pushed the jajerome/ENT-5350-backport branch 2 times, most recently from eb3d855 to 3f42fd0 Compare November 21, 2022 20:36
@DuckBoss DuckBoss marked this pull request as ready for review November 21, 2022 20:55
… binding

Card ID: ENT-5350
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2118486

- Implemented missing behavior of the "force" option
in Dbus API by unregistering the system if already registered
and re-registering the system.
- Added unit tests to check registration with force option
and registration when already registered.
@DuckBoss DuckBoss force-pushed the jajerome/ENT-5350-backport branch from 3f42fd0 to a7c233d Compare November 21, 2022 21:09
Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@ptoscano ptoscano merged commit 07eff33 into subscription-manager-1.28 Nov 22, 2022
@ptoscano ptoscano deleted the jajerome/ENT-5350-backport branch November 22, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants