Switch to shutil.which() & drop custom implementation #2898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnsnyder
requested review from
a team and
cnsnyder
and removed request for
a team
ptoscano
force-pushed
the
ptoscano/drop-custom-which
branch
from
11b3a32 to
35a15c3
Compare
Python 3.3 provides it, so switch to it since the required Python version is 3.6.
It is no more used now, so drop it along with its tests.
ptoscano
force-pushed
the
ptoscano/drop-custom-which
branch
from
35a15c3 to
39e1763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.3 provides
shutil.which(); since our required Python version is 3.6, then:which()toshutil.which()which()and the tests for itThere should be no behaviour change, as
shutil.which()does the right thing.