DASH/WASM: actually reject the DASH_WASM.initialize's Promise if it fails#1238
Merged
peaBerberian merged 1 commit intomasterfrom Apr 4, 2023
Merged
DASH/WASM: actually reject the DASH_WASM.initialize's Promise if it fails#1238peaBerberian merged 1 commit intomasterfrom
peaBerberian merged 1 commit intomasterfrom
Conversation
…ails I forgot to add a line on the implementation of the `DASH_WASM.initialize`J API (which allows to "initialize" the WASM-based DASH parser, i.e. load and compile its linked WebAssembly file), which led to the Promise returned by this method still resolved even if initialization fails. The error is still logged and the internal status of the `DASH_WASM` feature is still updated to indicate failure, but that's not what the application is most likely listening to.
peaBerberian
added
bug
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to add a line on the implementation of the
DASH_WASM.initializeAPI (which allows to "initialize", i.e. load and compile the linked WebAssembly file, the WASM-based DASH parser) which led to the Promise returned by this method still resolving even if the initialization failed.The error was still logged and the internal status of the
DASH_WASMfeature was still updated to indicate failure, but that's not what the application is most likely listening to.