migrate RaftRequestMetrics to micrometer #27769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/zeebe
entangled90
force-pushed
the
cs-26708-raft-request-metrics
branch
from
69dad22 to
b145845
Compare
entangled90
changed the base branch from
main
to
cs-26708-raft-filesystem-metrics
entangled90
added
backport stable/8.5
entangled90
force-pushed
the
cs-26708-raft-request-metrics
branch
2 times, most recently
from
bf26093 to
9b59a52
Compare
entangled90
force-pushed
the
cs-26708-raft-filesystem-metrics
branch
from
15118a7 to
41aa276
Compare
entangled90
force-pushed
the
cs-26708-raft-request-metrics
branch
from
9b59a52 to
d73dcaa
Compare
entangled90
force-pushed
the
cs-26708-raft-filesystem-metrics
branch
2 times, most recently
from
03a9294 to
468dd9e
Compare
entangled90
force-pushed
the
cs-26708-raft-request-metrics
branch
from
d73dcaa to
97a21b2
Compare
npepinpe
requested changes
Feb 7, 2025
zeebe/atomix/cluster/src/main/java/io/atomix/raft/metrics/RaftRequestMetrics.java
Show resolved
Hide resolved
| tpe -> | ||
| Counter.builder(RAFT_MESSAGE_RECEIVED.getName()) | ||
| .description(RAFT_MESSAGE_RECEIVED.getDescription()) | ||
| .tags(RaftKeyNames.TYPE.asString(), RaftKeyNames.PARTITION_GROUP.asString()) |
There was a problem hiding this comment.
❌ Does this mean the partition group key is the value of the type?
There was a problem hiding this comment.
My mistake, missing the type & partitionGroupName value
zeebe/atomix/cluster/src/main/java/io/atomix/raft/metrics/RaftRequestMetricsDoc.java
Show resolved
Hide resolved
npepinpe
approved these changes
Feb 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
# Description Backport of #27769 to `stable/8.6`. relates to #27754 #27608 original author: @entangled90
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
# Description Backport of #27769 to `stable/8.5`. relates to #27754 #27608 original author: @entangled90
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
# Description Backport of #27769 to `stable/8.7`. relates to #27754 #26078 original author: @entangled90
github-actions
bot
added
the
version:8.5.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate RaftRequestMetrics to micrometer. No dashboard changes expected
To be merged in main after #27754
Related issues
relates #27608