Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply suggestion #4664

Merged
merged 2 commits into from
Nov 26, 2024
Merged

chore: apply suggestion #4664

merged 2 commits into from
Nov 26, 2024

Conversation

jonathanlukas
Copy link
Contributor

@jonathanlukas jonathanlukas commented Nov 26, 2024

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@jonathanlukas jonathanlukas self-assigned this Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@jonathanlukas
Copy link
Contributor Author

Hi @mesellings , sorry but the last PR was set to auto merge.. I applied your suggested changes here.

Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@mesellings
Copy link
Contributor

Hi @mesellings , sorry but the last PR was set to auto merge.. I applied your suggested changes here.

No problem - thanks for making the change 👍

@jonathanlukas jonathanlukas enabled auto-merge (squash) November 26, 2024 13:41
@mesellings mesellings added component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Nov 26, 2024
@jonathanlukas jonathanlukas merged commit 4b5959f into main Nov 26, 2024
12 checks passed
@jonathanlukas jonathanlukas deleted the jonathanlukas-patch-1 branch November 26, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants