Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slash link to heading #4612

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Remove slash link to heading #4612

merged 1 commit into from
Nov 15, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented Nov 15, 2024

Description

Fixes the issue we only seem to see in #4598 and #4594 🥲 ?

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller marked this pull request as ready for review November 15, 2024 22:02
@akeller
Copy link
Member Author

akeller commented Nov 15, 2024

This both is and isn't a bug. I'm pretty confident we shouldn't have a link to a heading with .md/# and instead we drop the /, giving us .md#. Why this doesn't fail anywhere else other than my two Connectors PRs, and only remotely, is odd... and I don't understand it. I didn't touch these partials in my PRs. 🤷‍♀️

@akeller akeller added the component:docs Documentation improvements, including new or updated content label Nov 15, 2024
@akeller akeller mentioned this pull request Nov 15, 2024
9 tasks
Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD FIND 🕵️‍♀️

@akeller akeller merged commit fe7ac93 into main Nov 15, 2024
14 checks passed
@akeller akeller deleted the fix-partial-links branch November 15, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants