Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove user names in connectors and tasklist doc screenshots #4611

Merged

Conversation

christinaausley
Copy link
Contributor

Description

Relates to #2815. With just a few instances in cases like this, I'm fine with removing the header entirely, so long as this UI isn't required based on the docs commands.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added component:tasklist Issues related with Tasklist project component:docs Documentation improvements, including new or updated content component:connectors Issues related to the connectors project. labels Nov 15, 2024
@christinaausley christinaausley requested a review from a team November 15, 2024 18:53
@christinaausley christinaausley self-assigned this Nov 15, 2024
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this one slipped by me! I agree with your assessment - if the header isn't needed for directions/instructions, it seems simpler to just remove in these case. Thanks for updating these!

@christinaausley christinaausley merged commit 9873c65 into main Nov 19, 2024
11 checks passed
@christinaausley christinaausley deleted the remove-usernames-screenshots-connectors-tasklist branch November 19, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project. component:docs Documentation improvements, including new or updated content component:tasklist Issues related with Tasklist project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants