Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify installation steps for local kubernetes cluster #4606

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

vthiery
Copy link
Member

@vthiery vthiery commented Nov 15, 2024

Description

Instructions in steps 3 and 4 should be merged since they are both about installing with helm. If separate, a beginner might wonder what is to be done in step 3, whilst the command to run is in step 4.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Instructions in steps 3 and 4 should be merged since they are both about installing with helm. If separate, a beginner might wonder what is to be done in step 3, whilst the command to run is in step 4.
@conceptualshark conceptualshark added the component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed label Nov 15, 2024
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 Great catch, thank you!

@vthiery
Copy link
Member Author

vthiery commented Nov 29, 2024

@conceptualshark should I go ahead and merge myself, or is extra review needed?

@conceptualshark conceptualshark merged commit 29c30ff into main Dec 2, 2024
9 checks passed
@conceptualshark conceptualshark deleted the docs-local-kubernetes-cluster-install branch December 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants