Smartpen Milestone-1 #526
Merged
Smartpen Milestone-1 #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menu, Both modes, undo align To do: Better heuristics
Insiyaa
suggested changes
Jun 16, 2021
birm
reviewed
Jun 21, 2021
| @@ -155,6 +155,12 @@ | |||
| <script src="https://unpkg.com/@popperjs/core@2"></script> | |||
| <script src="https://unpkg.com/tippy.js@6"></script> | |||
|
|
|||
| <!-- Smartpen --> | |||
| <script type="text/javascript" src="../../common/enhance.js"></script> | |||
| <script type="text/javascript" src="../../common/smartpen/autoalign.js"></script> | |||
There was a problem hiding this comment.
I don't quite understand why you've added this here, I couldn't notice anything in the heatmap app. Is this coming functionality?
There was a problem hiding this comment.
Actually the smartpen is a part of openseadragon-canvas-draw-overlay. Currently, even if not used, the file has to be included with it. Haven't explored the heatmaps section, but if there is any need, smartpen can be activated with a line of code.
Comment on lines
-1775
to
+1780
| saveAnnotation(); | ||
| $CAMIC.viewer.canvasDrawInstance.isOn = false; |
There was a problem hiding this comment.
Just noting that this looks like it changes the behavior of the pencil in single draw mode to not save automatically. I'm ok with this, but @nanli-emory may have the same/different opionion.
birm
approved these changes
Jun 23, 2021
Insiyaa
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smartpen Milestone 1 #523
Contains
I have added the feature to annotations and preset label. This can be extended to anyother tab easily. I tested it, it works well. It supports any kind of annotations (freestyle, rectangles etc).
Code details
Written the edge detection in
enhance.js. Written the smartpen class inautoalign.js,autoalign.css. Integrated the code inopenseadragon-canvas-draw-overlay, added it to viewer inuicallbacks.jsTo dos
Feel free to provide suggestions, improvements, contributions related to the implementation or UI. And please review