[MRG] "Be Cordial or Be on Your Way" and Camelot Project PDF not Working #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperlinks to Kenneth Reitz' essay in CODE_OF_CONDUCT.md and CONTRIBUTING.md are dead along with Camelot Project PDF showing ads Issue:364 Signed-off-by:Kshitiz Gupta <[email protected]>
|
The changes are related to the links in the documentation thus the success of the test is not quite important |
|
@johnnymetz @christinegarcia @vinayak-mehta Whenever you are free kindly have a look on this PR as it is related to the documentation hyperlink changes and should be quick as the passing of the test should not be affected by it. |
foarsitter
approved these changes
Jul 14, 2023
|
Thanks @kshitiz305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyperlinks to Kenneth Reitz' essay in CODE_OF_CONDUCT.md and CONTRIBUTING.md are dead along with Camelot Project PDF showing ads
Issue: #364
Link: #364
Signed-off-by: Kshitiz Gupta [email protected]