Associate Camel K schema when modeline is available #483

apupier · 2020-07-16T12:52:17Z

apupier · 2020-07-22T15:37:25Z

this is failing due to redhat-developer/vscode-yaml#323 (well more that VS Code Kubernetes extension is throwing an error but it will be more robust if the error is caught at VS Code Yaml level)

apupier · 2020-07-23T12:41:41Z

src/CamelKSchemaManager.ts

+}
+
+function getCamelKSchemaUrl(): string {
+	return 'https://raw.githubusercontent.com/apache/camel-k-runtime/master/camel-k-loader-yaml/camel-k-loader-yaml/src/generated/resources/camel-yaml-dsl.json';


hardcoded. planning to provide a settings to let user modify it in another task https://issues.redhat.com/browse/FUSETOOLS2-571

apupier · 2020-08-21T08:19:24Z

job is green on CI, github is not updatign the status: https://travis-ci.org/github/camel-tooling/vscode-camelk/builds/719861172

CHANGELOG.md

src/CamelKSchemaManager.ts

lhein · 2020-08-21T08:38:46Z

src/CamelKSchemaManager.ts

+		&& textDocument.getText().startsWith(CAMELK_MODELINE_PREFIX)) {
+			return CAMELK_SCHEMA_URI_PREFIX + resource;
+		}
+	return undefined;


I think that is the default if you don't specify it, but I could be wrong.

if you are not sure, it means that it is easier to understand when specifying it

yeah, was just thinking loud. I am fine with the current way you handle it.

src/CamelKSchemaManager.ts

bfitzpat · 2020-08-21T17:12:42Z

@apupier -- What's the use case for this? User creates a new, blank yaml and wants to create a camel k file? Not arguing that it's not helpful, but wondering where the user is coming at this from. If they create a new yaml Camel K file through the Camel K extension, this is done for them already, right?

apupier · 2020-08-23T19:38:54Z

What's the use case for this? User creates a new, blank yaml and wants to create a camel k file?

Camel K developers doesn't want to impose *.camelk.yaml file name pattern.

Not arguing that it's not helpful, but wondering where the user is coming at this from.

coming at request from Luca

If they create a new yaml Camel K file through the Camel K extension, this is done for them already, right?

no, when creating from Command Palette, it is reusing the kamel init command and then it is creating with .yaml and not .camelk.yaml

specified and the filename doesn't match the file name pattern Signed-off-by: Aurélien Pupier <[email protected]>

apupier mentioned this pull request Jul 16, 2020

Automatic linking of Camel K schema based on Camel K modeline redhat-developer/yaml-language-server#279

Closed

apupier force-pushed the relyOnCamelKModelineToAssociateSchema branch 4 times, most recently from f6b5f4c to b6b90bd Compare July 22, 2020 09:01

apupier force-pushed the relyOnCamelKModelineToAssociateSchema branch 2 times, most recently from 971cf95 to 782ac3d Compare July 23, 2020 12:27

apupier changed the title ~~WIP Associate Camel K schema when modeline is available~~ Associate Camel K schema when modeline is available Jul 23, 2020

apupier force-pushed the relyOnCamelKModelineToAssociateSchema branch from 782ac3d to d92ae0b Compare July 23, 2020 12:42

apupier force-pushed the relyOnCamelKModelineToAssociateSchema branch 2 times, most recently from a59621e to b187d49 Compare August 21, 2020 07:43

apupier commented Aug 21, 2020

View reviewed changes

apupier force-pushed the relyOnCamelKModelineToAssociateSchema branch 4 times, most recently from d818db0 to 458ed19 Compare August 21, 2020 08:09

apupier requested review from bfitzpat and lhein August 21, 2020 08:19

apupier added the READY FOR REVIEW label Aug 21, 2020