Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Phi-3.5-vision-instruct VLM model #975

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

NeilJohnson0930
Copy link
Collaborator

@NeilJohnson0930 NeilJohnson0930 commented Sep 20, 2024

Description

Add Phi-3.5-vision-instruct VLM model

Motivation and Context

close #849

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@NeilJohnson0930 NeilJohnson0930 added this to the Sprint 12 milestone Sep 20, 2024
@NeilJohnson0930 NeilJohnson0930 linked an issue Sep 20, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan added Model Related to backend models New Feature labels Sep 23, 2024
@Wendong-Fan Wendong-Fan changed the title Add Phi-3.5-vision-instruct VLM model feat: Add Phi-3.5-vision-instruct VLM model Sep 23, 2024
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NeilJohnson0930 , left some initial comment below

camel/configs/phi_config.py Outdated Show resolved Hide resolved
camel/configs/phi_config.py Show resolved Hide resolved
camel/configs/phi_config.py Outdated Show resolved Hide resolved
camel/models/phi_model.py Outdated Show resolved Hide resolved
camel/models/phi_model.py Outdated Show resolved Hide resolved
camel/models/phi_model.py Outdated Show resolved Hide resolved
camel/models/phi_model.py Outdated Show resolved Hide resolved
camel/models/phi_model.py Outdated Show resolved Hide resolved
camel/models/phi_model.py Outdated Show resolved Hide resolved
camel/models/phi_model.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Model Related to backend models New Feature
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Phi-3.5-vision-instruct VLM model
2 participants