Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retriever cookbook and utils change #472

Merged
merged 32 commits into from
Mar 27, 2024

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Mar 16, 2024

Description

This this a sub PR of #410 only containing retriever cookbook and utils change based on auto retriever, with a small typo fix

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Mar 16, 2024
Copy link

coderabbitai bot commented Mar 16, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Wendong-Fan Wendong-Fan added the documentation Improvements or additions to documentation label Mar 16, 2024
@Wendong-Fan Wendong-Fan marked this pull request as ready for review March 16, 2024 13:36
Copy link
Member

@Appointat Appointat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the code and left some simple modification suggestions (some regarding formatting). Well, I'm not sure if I missed anything in the dev meeting. Could you please explain to me why you're moving the role_playing... function into commons.py? Thanks

camel/utils/commons.py Show resolved Hide resolved
camel/utils/commons.py Outdated Show resolved Hide resolved
camel/utils/commons.py Outdated Show resolved Hide resolved
Wendong-Fan and others added 3 commits March 17, 2024 16:14
Co-authored-by: Appointat <[email protected]>
Co-authored-by: Appointat <[email protected]>
Co-authored-by: Appointat <[email protected]>
@Wendong-Fan
Copy link
Member Author

I've reviewed the code and left some simple modification suggestions (some regarding formatting). Well, I'm not sure if I missed anything in the dev meeting. Could you please explain to me why you're moving the role_playing... function into commons.py? Thanks

Hey @Appointat , thanks for the review, in the cookbook I used role_playing... function as example, I think this function will be regularly used as a common example function to show how to implement tasks with multi-agents, so I moved this function into utils

Base automatically changed from feature/auto_retriever to master March 27, 2024 10:19
@Wendong-Fan Wendong-Fan merged commit e080f25 into master Mar 27, 2024
6 checks passed
@Wendong-Fan Wendong-Fan deleted the feature/retriever_cookbook_and_utils branch March 27, 2024 12:19
Comment on lines +243 to +281
def role_playing_with_function(
task_prompt: str = ("Assume now is 2024 in the Gregorian calendar, "
"estimate the current age of University of Oxford "
"and then add 10 more years to this age, "
"and get the current weather of the city where "
"the University is located."),
function_list: Optional[List] = None,
model_type=None,
chat_turn_limit=10,
assistant_role_name: str = "Searcher",
user_role_name: str = "Professor",
) -> None:
r"""Initializes and conducts a `RolePlaying` with `FunctionCallingConfig`
session. The function creates an interactive and dynamic role-play session
where the AI Assistant and User engage based on the given task, roles, and
available functions. It demonstrates the versatility of AI in handling
diverse tasks and user interactions within a structured `RolePlaying`
framework.

Args:
task_prompt (str): The initial task or scenario description to start
the `RolePlaying` session. Defaults to a prompt involving the
estimation of KAUST's age and weather information.
function_list (list): A list of functions that the agent can utilize
during the session. Defaults to a combination of math, search, and
weather functions.
model_type (ModelType): The type of chatbot model used for both the
assistant and the user. Defaults to `GPT-4 Turbo`.
chat_turn_limit (int): The maximum number of turns (exchanges) in the
chat session. Defaults to 10.
assistant_role_name (str): The role name assigned to the AI Assistant.
Defaults to 'Searcher'.
user_role_name (str): The role name assigned to the User. Defaults to
'Professor'.

Returns:
None: This function does not return any value but prints out the
session's dialogues and outputs.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the role_playing_with_function example is moved to utils?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not put hard coded example into utils.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the role_playing_with_function example is moved to utils?

Hey @lightaime , in the RAG cookbook I used role_playing_with_function as example,

from camel.utils import role_playing_with_function
from camel.functions import MATH_FUNCS  # import another function from camel

role_playing_with_function(
    task_prompt=(
        "What is the main termination reasons for AI Society dataset, how many number of messages did camel decided to limit, what's the value plus 100?"
    ),
    function_list=[*RETRIEVER_FUNCS, *MATH_FUNCS],
)

I think this function will be regularly used as a common example function to show how to implement tasks by using different functions with multi-agents, so I moved this function into utils, even this function has set default values, it still allows the user to input their own parameters including task_prompt, function_list,model_type, chat_turn_limit, assistant_role_name,user_role_name to adjust the behavior of this function with flexibility.

Copy link
Member Author

@Wendong-Fan Wendong-Fan May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for later integrated tools/function, we can use this role_playing_with_function to easily test/show how it works, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Merged or Closed
Development

Successfully merging this pull request may close these issues.

3 participants