feat: Add Discord OAuth Flow and Bot Public Thread with History Response Feature #1129
Conversation
…threads and responding with the chat history features
|
Thanks @AveryYay , I will review the code and assist you in completing the PR integration |
There was a problem hiding this comment.
Thanks @AveryYay , good code! left some comments below.
And in terms of functionality, I hope you refer to camel.bots.slack.slack_app.py and integrate the oauth process into camel.bots.discord.discord_app.py (you can create camel.bots.discord to store module content)
|
|
||
| user_data = await self.oauth_client.get_user_info(access_token) | ||
| logger.info(f"User data: {user_data}") | ||
| await self.shutdown_oauth_server() |
There was a problem hiding this comment.
| await self.shutdown_oauth_server() |
Server is a long-term service, so it's better to let users manually shut it down
There was a problem hiding this comment.
Example can be combined with the usage of chat_agent to integrate existing historical records into the memory of chat_agent.
Wendong-Fan
changed the title
There was a problem hiding this comment.
Thanks @AveryYay ! Overall LGTM, left some comments below, It would be better if we could also add docstring for DiscordOAuth
BTW, you can run pre-commit run --all-files before the push to ensure the code pass pre-commit check
| token: Optional[str] = None, | ||
| client_id: Optional[str] = None, | ||
| client_secret: Optional[str] = None, | ||
| redirect_uri: str = "http://localhost:8000/callback", |
| response = await client.post(TOKEN_URL, data=data, headers=headers) | ||
| response_data = response.json() |
There was a problem hiding this comment.
before fetch the data, check the status code first like below?
if response.status_code != 200:
logger.error("Failed to exchange code for token)
return None
| user_response = await client.get(USER_URL, headers=headers) | ||
| return user_response.json() |
| self.server.should_exit = True | ||
| logger.info("Shutting down the OAuth server.") |
There was a problem hiding this comment.
should we add await here to make sure the server is fully stopped?
Description
This PR introduces 2 components:
Motivation and Context
This change adds two distinct functionalities:
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!