Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: toolkits #1012

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

refactor: toolkits #1012

wants to merge 31 commits into from

Conversation

Wendong-Fan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@ZackYule ZackYule self-assigned this Oct 12, 2024
@ZackYule
Copy link
Collaborator

ZackYule commented Oct 15, 2024

At this point, all toolkit usage methods are fully supported, and the presentation of these methods has been unified (with the exception of OpenAPIToolkit):
Toolkits that don’t support FUNCS and require configuration no longer need to have the get_tools method manually written;
Toolkits that do support FUNCS should define tools as functions and override the get_tools method in a standardized format.

@ZackYule
Copy link
Collaborator

Initial support has been added for using multiple tool instances within the same toolkit class, but further improvements will require adding support for modifying the docstrings of tool instances.

@Wendong-Fan Wendong-Fan changed the title Refactor/toolkits refactor: toolkits Oct 15, 2024
@yiyiyi0817
Copy link
Member

At this point, all toolkit usage methods are fully supported, and the presentation of these methods has been unified (with the exception of OpenAPIToolkit): Toolkits that don’t support FUNCS and require configuration no longer need to have the get_tools method manually written; Toolkits that do support FUNCS should define tools as functions and override the get_tools method in a standardized format.

If needed, I can help to integrate OpenAPIToolkit to the Tookit Manager.

@ZackYule
Copy link
Collaborator

At this point, all toolkit usage methods are fully supported, and the presentation of these methods has been unified (with the exception of OpenAPIToolkit): Toolkits that don’t support FUNCS and require configuration no longer need to have the get_tools method manually written; Toolkits that do support FUNCS should define tools as functions and override the get_tools method in a standardized format.

If needed, I can help to integrate OpenAPIToolkit to the Tookit Manager.

That would be great. Thanks @yiyiyi0817

@Wendong-Fan Wendong-Fan marked this pull request as ready for review November 4, 2024 13:46
@Wendong-Fan Wendong-Fan added this to the Sprint 15 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants