mediatypes: add band-aid for quay.io handling#82
Conversation
1e71fdf to
7b7df81
Compare
Since recently quay.io appends `; charset=utf-8` in the `content-type` header value for HEAD requests on the `manifests` endpoint. This patch restores functionality as before the quay.io change.
7b7df81 to
4f8a181
Compare
|
This PR is unfortunately wrong (and I fear the change on quay.io side too). Media-types are part of the docker-registry API specifications. The V2S1 types are defined here and they don't have any additional (including charset) parameters. Additionally, those manifests are explicitly compatible with @thomasmckay @josephschorr any chance to revert the change on quay, and align it back with IETF and docker-registry specs? |
|
@lucab We can certainly revert, but we'd have to double check on what Docker is returning for manifests. The problem is the Docker documentation itself shows |
|
For reference, the quay.io change was reverted in the meanwhile. It was breaking kubernetes CI too: kubernetes/kubernetes#72863 (comment) |
Since recently quay.io appends
; charset=utf-8in thecontent-typeheader value for HEAD requests on the
manifestsendpoint. This patchrestores functionality as before the quay.io change.