Add support for OCI Image Manifest #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a follow up, I am happy to revive #244 if @luizribeiro can't get to it. |
Previously, a generic error would be returned: ``` Error: unexpected HTTP status 404 Not Found ``` This does not convey much information as to what happens. On the current version of dkregistry, one would hit this when trying to access s390x/ubuntu on registry-1.docker.io. This change specializes the error to surface more information as to why the error is happening as described in the OCI Distribution Specification: https://github.com/opencontainers/distribution-spec/blob/main/spec.md#error-codes In this specific case, the error would look like: ``` Error: Api Error: ((MANIFEST_UNKNOWN), message: OCI manifest found, but accept header does not support OCI manifests) Caused by: ((MANIFEST_UNKNOWN), message: OCI manifest found, but accept header does not support OCI manifests) ``` which clearly highlight that dkregistry does not support OCI manifest.
Image like s390x/ubuntu uses OCI Image Manifest, which per https://github.com/opencontainers/image-spec/blob/v1.0.1/manifest.md is very similar to vnd.docker.distribution.manifest.v2. Add a test to confirm we can deserialize an OCI Image Manifest as a ManifestSchema2Spec. Also add a test to confirm that we can now fetch the manifest from docker.io. Previously it would fail with MANIFEST_UNKNOWN.
OCI Image Index (https://github.com/opencontainers/image-spec/blob/v1.0.1/image-index.md) is similar to vnd.docker.distribution.manifest.list.v2 This revives camallo#244 originally created by @luizribeiro A testing client could pull koenkk/zigbee2mqtt:latest with this change. Fixes camallo#243
chantra
force-pushed
the
support_oci_manifest
branch
from
0a337d4
to
035f1a5
Compare
|
@PratikMahajan if you could look into this one too, that would be great. |
PratikMahajan
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image like s390x/ubuntu uses OCI Image Manifest, which per
https://github.com/opencontainers/image-spec/blob/v1.0.1/manifest.md
is very similar to vnd.docker.distribution.manifest.v2.
Add a test to confirm we can deserialize an OCI Image Manifest as a ManifestSchema2Spec.
Also add a test to confirm that we can now fetch the manifest from docker.io.
Previously it would fail with MANIFEST_UNKNOWN.
This is built on top of #260 . I stacked it because it would otherwise have merge conflicts due to the tests.