Skip to content

Conversation

@StrawnSC
Copy link
Collaborator

@StrawnSC StrawnSC commented Aug 18, 2022

Fixes Azure#5253

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

disable_warnings=False,
user_assigned=None,
registry_identity=None):
if image and "/" in image and not registry_server:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StrawnSC I would assume this was added in first place for a reason - would there be any issues with removing this - that might need to be handled separately.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this was a last-minute change that we made in the last version because we thought it would make the user experience better. We had the faulty assumption that the user would always want to set a registry server value if they pass in an image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, all our testing of the MSI feature for az containerapp create involved using ACR registries like so:
az containerapp create --image sstrawn.azurecr.io/image:tag --registry-server sstrawn.azurecr.io
Based on that usage of the create command, it seemed like we could easily help the user our by trying to parse out the registry server from the --image value. For anonymous registries, the user doesn't need to add the --registry-server value, so this feature broke that use case

@panchagnula
Copy link
Collaborator

This looks good - only ask like we discussed is to add a test for anonymous registries so we can catch any issues in our testing.

@StrawnSC StrawnSC merged commit 5bfb856 into calvinsID:containerapp-0.3.10 Aug 19, 2022
@StrawnSC StrawnSC deleted the aca_create_bug branch August 19, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants