Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth Perception #15

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Depth Perception #15

wants to merge 5 commits into from

Conversation

richagadgil
Copy link
Member

No description provided.

@richagadgil
Copy link
Member Author

As of now: Scale not appearing in Overlay

@richagadgil
Copy link
Member Author

DO NOT MERGE!!!

@richagadgil richagadgil marked this pull request as draft May 16, 2021 21:23
@Waidhoferj Waidhoferj changed the title depth Perception Depth Perception Jul 25, 2021
@Waidhoferj
Copy link
Member

Fixes #3,
Fixes #7,
Fixes #8

Changes

  • Added portal action option
  • Added action icons
  • Integrated depth estimation into overlay additions, updates and saves
  • Synced types with the frontend (see Tour Schema Refactor)
  • Updated position coordinate system. Instead of representing [x,y,z] which is variable based on the size of the device, panorama and the sphere, position now refers to [normalized_theta, normalized_phi, depth]` (spherical coordinate resource)

Testing

  • Spin up the Argo Backend.
  • Launch Argo Editor
  • Try adding a portal action on an overlay and verify that there are no errors.
  • Add/ move around overlay.
  • Launch virtual tour concept
  • Navigate to panorama location with new content.
  • Verify that new content exists in the virtual tour.

@Waidhoferj Waidhoferj marked this pull request as ready for review August 8, 2021 23:50
@Waidhoferj Waidhoferj mentioned this pull request Aug 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameron-toy cameron-toy Awaiting requested review from cameron-toy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richagadgil @Waidhoferj