-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Parallel
applicative and also breakingly...
#23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 99.15% 99.29% +0.13%
==========================================
Files 1 1
Lines 237 282 +45
Branches 26 36 +10
==========================================
+ Hits 235 280 +45
Misses 2 2
Continue to review full report at Codecov.
|
d7c034f
to
e6c0038
Compare
e6c0038
to
8f5ab38
Compare
a9c6313
to
0d1c39d
Compare
...changed `template` and `apply` to work in parallel and renamed `[upH|downH|h]asFailed` to `[upH|downH|h]asErrored`.
0d1c39d
to
71537dd
Compare
Hi @polytypic. I've finally reached the point of swapping out our app's API fetching layer and really need this What do you feel is left before we merge this? I checked out the branch and the tests are passing. I've also added it to my work in progress branch in our app and it's just what I need. Happy to help get it shipped if you feel it needs anything else. |
Hmm... I don't recall anything particular. So, maybe review once more, merge, and publish if all looks good. |
Sounds good. I've read through everything carefully and it looks good but I don't quite understand why we need the Any objection to releasing this as |
Yes, otherwise the subscription would be dropped momentarily resulting in repeating the subscription effect (abort and restart request). See here. |
@polytypic I added |
...changed
template
andapply
to work in parallel and renamed[upH|downH|h]asFailed
to[upH|downH|h]asErrored
.