chore: bump RN to 0.62 #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
commented
Apr 17, 2020
| @@ -57,7 +57,9 @@ describe('fireEvent', () => { | |||
| }); | |||
|
|
|||
| test('should throw an Error when event handler was not found', () => { | |||
| const { getByTestId } = render(<WithoutEventComponent />); | |||
| const { getByTestId } = render( | |||
| <WithoutEventComponent onPress={() => 'this is not passed to children'} /> | |||
There was a problem hiding this comment.
Based on #28 I've added this instead of the should not bubble event to root element test that started to fail
thymikee
commented
Apr 17, 2020
Comment on lines
-82
to
-92
| test('should not bubble event to root element', () => { | ||
| const onPressMock = jest.fn(); | ||
| const { getByTestId } = render( | ||
| <TouchableOpacity onPress={onPressMock}> | ||
| <Text testID="test">Content</Text> | ||
| </TouchableOpacity> | ||
| ); | ||
|
|
||
| expect(() => fireEvent.press(getByTestId('test'))).toThrow(); | ||
| expect(onPressMock).not.toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
This test seems fishy and not testing what it's supposed to. Not really sure why it didn't fail earlier, since the test testID is there, we can press it, and closest onPress is bound, so it should be called.
cross19xx
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blocked by facebook/react-native#28520
Test plan
CI passes