Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace missing word in ActivityIndicator.tsx #4612

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

meatnordrink
Copy link
Contributor

@meatnordrink meatnordrink commented Jan 23, 2025

Motivation

Seems like a word in this sentence was accidentally dropped, "replacement". (The phrase in English is that something is a "drop-in replacement", not a "drop-in" - a "drop-in" refers, rather, to a patient who has arrived at a medical office without an appointment.)

Replacing the word just adds a bit more clarity to the instructions for the component, and reduces potential confusion.

Related issue

N/A

Test plan

Just look at the docs page.

@callstack-bot
Copy link

Hey @meatnordrink, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

Copy link
Contributor

@BogiKay BogiKay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Now the description is clearer and more precise.

Thanks for your contribution!

@BogiKay BogiKay added the docs label Jan 25, 2025
@BogiKay BogiKay merged commit c488fc3 into callstack:main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants