fix: input label not visible on ios if multiline, fixes #4482 #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @damianfilipek81, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
@gedu Is this planned to be merged? Still an issue in |
BogiKay
requested changes
Jan 25, 2025
| @@ -138,7 +138,7 @@ const InputLabel = (props: InputLabelProps) => { | |||
| // This gives the effect of animating the color, but allows us to use native driver | |||
| <View | |||
| pointerEvents="none" | |||
| style={[StyleSheet.absoluteFill, styles.overflow]} | |||
There was a problem hiding this comment.
I don't think we need to apply styles.labelContainer twice. Can you get rid of it from line 147?
|
Worth checking that this PR fixes the issue on web as well. Since I posted the issue (#4482) I found this also is a problem on web. |
|
@ericpoulinnz I tested it and the issue is gone on web as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR solves this issue. "When focusing into a TextInput (when mode='flat'), the label disappears. It shows up normally when multiline=false, and this is only a problem on iOS."
Related issue
issue
Test plan
I've checked it on ios simulator and android emulator, since example project is on expo 48 i cannot install it on my phone.
I've also updated
TextInput.test.tsx.snapsnapshot since tests were failing.