Fix newArch issue with no feedback on android #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troZee
approved these changes
Aug 26, 2024
|
Did you manage to dig down into how yoga resolves those views? I'd be curious to follow the progress on this issue 👀 |
still looking into it, trying to figure out other solution |
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Sep 7, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-pager-view](https://github.com/callstack/react-native-pager-view) | [`^6.3.4` -> `^6.4.1`](https://renovatebot.com/diffs/npm/react-native-pager-view/6.3.4/6.4.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>callstack/react-native-pager-view (react-native-pager-view)</summary> ### [`v6.4.1`](https://github.com/callstack/react-native-pager-view/releases/tag/v6.4.1) [Compare Source](https://github.com/callstack/react-native-pager-view/compare/v6.4.0...v6.4.1) #### What's Changed - feat: add load method by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/callstack/react-native-pager-view/pull/867](https://github.com/callstack/react-native-pager-view/pull/867) - Update README.md by [@​yilinjuang](https://github.com/yilinjuang) in [https://github.com/callstack/react-native-pager-view/pull/870](https://github.com/callstack/react-native-pager-view/pull/870) - fix(android): newArch issue with no feedback on android by [@​MrRefactor](https://github.com/MrRefactor) in [https://github.com/callstack/react-native-pager-view/pull/865](https://github.com/callstack/react-native-pager-view/pull/865) #### New Contributors - [@​WoLewicki](https://github.com/WoLewicki) made their first contribution in [https://github.com/callstack/react-native-pager-view/pull/867](https://github.com/callstack/react-native-pager-view/pull/867) - [@​yilinjuang](https://github.com/yilinjuang) made their first contribution in [https://github.com/callstack/react-native-pager-view/pull/870](https://github.com/callstack/react-native-pager-view/pull/870) **Full Changelog**: callstack/react-native-pager-view@v6.4.0...v6.4.1 ### [`v6.4.0`](https://github.com/callstack/react-native-pager-view/releases/tag/v6.4.0) [Compare Source](https://github.com/callstack/react-native-pager-view/compare/v6.3.4...v6.4.0) Changelog: - fix(android): Fix android newArch build ([#​864](https://github.com/callstack/react-native-pager-view/issues/864)) ([`12e29d5`](https://github.com/callstack/react-native-pager-view/commit/12e29d5)) [@​MrRefactor](https://github.com/MrRefactor) - fix(ios): Change RNCViewPagerComponenDescriptor import ([#​863](https://github.com/callstack/react-native-pager-view/issues/863)) ([`0f4bac8`](https://github.com/callstack/react-native-pager-view/commit/0f4bac8)) [@​MrRefactor](https://github.com/MrRefactor) - fix(ios): visionOS builds ([`cca654a`](https://github.com/callstack/react-native-pager-view/commit/cca654a)) [@​okwasniewski](https://github.com/okwasniewski) - chore(example): migrate example to `react-native-test-app` ([`ea11c94`](https://github.com/callstack/react-native-pager-view/commit/ea11c94)) [@​szymonrybczak](https://github.com/szymonrybczak) - fix(android): child argument types in addView methods ([#​857](https://github.com/callstack/react-native-pager-view/issues/857)) ([`993928c`](https://github.com/callstack/react-native-pager-view/commit/993928c)) [@​szydlovsky](https://github.com/szydlovsky) - fix(js): remove RCTEventEmitter workaround ([#​858](https://github.com/callstack/react-native-pager-view/issues/858)) ([`1e61a59`](https://github.com/callstack/react-native-pager-view/commit/1e61a59)) [@​MrRefactor](https://github.com/MrRefactor) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Just trust me ok?What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md