-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix child argument types in addView
methods
#857
Fix child argument types in addView
methods
#857
Conversation
Someone please accept this PR. its urgent fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work for RN < 75 and the old arch?
there is also addView inside main/PagerViewViewManagerImpl.kt |
@troZee checked for RN 0.74.4 on both old and new arch - worked fine. 0.75.1 both arches work as well |
and yeah, |
@troZee should I also add changes to the Implementation files? |
Thank you very much. When will the version be released |
Summary
Fixes #850 and #856.
As stated in the first issue, there seem to be unneeded nullabilities in
child
arguments for Android PagerViewManager (both paper and fabric). Their existence makes the methods override nothing, which in turn crashes the build.Test Plan
Run on a fresh android app.
What's required for testing (prerequisites)?
Having anything
react-native-pager-view
related in the app.What are the steps to reproduce (after prerequisites)?
You need to create 2 differents apps - one with RN 0.74, the other with RN 0.75 - to make sure we don't lose <0.75 compatibility. Then, after installing dependencies just try building via Android Studio.
Compatibility
Checklist
README.md