fix: pager reporting incorrect position when being moved by nested scroll view #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troZee
approved these changes
Jul 31, 2025
okwasniewski
commented
Jul 31, 2025
okwasniewski
force-pushed
the
fix/onscroll-nested-scrollviews
branch
from
09f3c01 to
eb928b4
Compare
krozniata
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes pager being moved by nested scroll views.
When embedding a horizontal scroll view into a (horizontal) pager view dragging on the scroll view can cause pager's scroll view to move. Before the onScroll event wasn't setting destination index in that case which made it report incorrect position.
Before
ScreenRecording_07-31-2025.6-06-51.PM_1.MP4
Pay close attention to this progress bar 👆
After
ScreenRecording_07-31-2025.6-07-42.PM_1.MP4
Test Plan
Check new horizontal scroll example
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md