Skip to content

Conversation

@okwasniewski
Copy link
Member

Summary

This PR cleans up the code for iOS implementation.

  • Move retrieval of event emitter to one shared function, (same as built-in React Native modal)
  • Use #pragma mark for logic grouping of code
  • Simplify conditions in scrollViewDidScroll

Test Plan

Test if everything works the same

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@okwasniewski okwasniewski requested a review from Copilot July 31, 2025 15:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the iOS implementation of a React Native pager component to improve code organization and maintainability. The main focus is on cleaning up repetitive code patterns and improving logical grouping of methods.

  • Extracted event emitter retrieval into a shared helper function
  • Added #pragma mark directives to organize code into logical sections
  • Simplified the scrollViewDidScroll method implementation

@okwasniewski okwasniewski merged commit 4b64803 into master Jul 31, 2025
2 checks passed
@okwasniewski okwasniewski deleted the feat/cleanup branch July 31, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants