fix(rubyforgood#4248): remove wait_for_ajax helper, using wait sele…

…ct option
callmarx · Apr 17, 2024 · 4fbd3b1 · 4fbd3b1
1 parent c83e91b
commit 4fbd3b1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/spec/support/wait_for_ajax.rb b/spec/support/wait_for_ajax.rb
diff --git a/spec/system/adjustment_system_spec.rb b/spec/system/adjustment_system_spec.rb
@@ -21,7 +21,7 @@
       end
 
       it "allows you to choose items that do not yet exist" do
-        wait_for_ajax
+        expect(page).to have_select("adjustment_line_items_attributes_0_item_id", with_options: [item.name], wait: 10)
         select Item.active.last.name, from: "adjustment_line_items_attributes_0_item_id"
         fill_in "adjustment_line_items_attributes_0_quantity", with: add_quantity.to_s
 

diff --git a/spec/system/distribution_system_spec.rb b/spec/system/distribution_system_spec.rb
@@ -119,7 +119,7 @@
         visit @url_prefix + "/distributions/new"
         select @partner.name, from: "Partner"
         select @storage_location.name, from: "From storage location"
-        wait_for_ajax
+        expect(page).to have_select("distribution_line_items_attributes_0_item_id", with_options: [item.name], wait: 10)
         select item.name, from: "distribution_line_items_attributes_0_item_id"
         fill_in "distribution_line_items_attributes_0_quantity", with: 18