fix: incorporate review feedback from #799 #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefsale
approved these changes
Oct 16, 2024
chefsale
reviewed
Oct 16, 2024
chefsale
reviewed
Oct 16, 2024
chefsale
reviewed
Oct 16, 2024
danwilliams
approved these changes
Oct 16, 2024
miraclx
force-pushed
the
miraclx/fixup/feat/wasm-extras
branch
3 times, most recently
from
81051f7
to
895ebfb
Compare
chefsale
approved these changes
Oct 17, 2024
chefsale
force-pushed
the
feat/crdt-based-storage
branch
from
08af140
to
07246a3
Compare
chefsale
force-pushed
the
miraclx/fixup/feat/wasm-extras
branch
from
056a5fe
to
dfe6eff
Compare
miraclx
force-pushed
the
miraclx/fixup/feat/wasm-extras
branch
from
c6354e6
to
886df88
Compare
miraclx
added a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
miraclx
added a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
danwilliams
pushed a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
danwilliams
pushed a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
danwilliams
pushed a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
miraclx
added a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
miraclx
added a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
miraclx
added a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
miraclx
added a commit
that referenced
this pull request
Oct 24, 2024
NOTE: TESTS ARE CURRENTLY BROKEN.
- Removed VMLogic::generate_uuid.
- Removed UUID dependency from runtime & SDK.
- Generalized sys::generate_uuid to sys::random_bytes.
- Optimized sized data exchanged between the runtime and the SDK,
skipping register heap allocations & copying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMLogic::generate_uuid- refuuiddep from runtime & SDK - refsys::generate_uuidtosys::random_bytes- refuuidin root manifest - reffixedstr,axum-serverwill be addressed in a separate PR targetingmasteradditionally, this includes optimizations for sized data exchanged between the runtime and the SDK, skipping register heap allocations & copying