-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show add to calendar section for customers after booking an event #17761
base: main
Are you sure you want to change the base?
feat: Show add to calendar section for customers after booking an event #17761
Conversation
@coder-adnan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
This pull request fixes the issue of showing the "Add to calendar" section on the booking confirmation page for non-host users. Previously, this section was only visible to the host, which could lead to customers forgetting to add the event to their calendars and potentially missing the meeting. The changes made include modifying the condition in the bookings-single-view.tsx file to ensure that the "Add to calendar" section is displayed for customers as well. This will help reduce no-shows by making it easier for customers to add the event to their calendars directly from the confirmation page. Additionally, test cases in the bookings-single-view.test.tsx file have been updated to cover this new functionality, ensuring that the section is correctly displayed and functional for customers. This fix addresses GitHub issue #17749. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (11/20/24)1 label was added to this PR based on Keith Williams's automation. |
@@ -202,7 +202,8 @@ export default function Success(props: PageProps) { | |||
}; | |||
|
|||
function setIsCancellationMode(value: boolean) { | |||
const _searchParams = new URLSearchParams(searchParams ?? undefined); | |||
// Convert ReadonlyURLSearchParams to URLSearchParams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment.
Hey @coder-adnan please Sign CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @coder-adnan, can you please attach a screen recording of the fix?
What does this PR do?
This PR modifies the booking confirmation page to show the "Add to calendar" section for customers after booking an event. This change aims to help prevent no-shows by making it easier for customers to add the event to their calendars.
Mandatory Tasks
How should this be tested?
The test performed successful to show the
This PR modifies the booking confirmation page to show the "Add to calendar" section for customers after booking an event. This change aims to help prevent no-shows by making it easier for customers to add the event to their calendars.