Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show add to calendar section for customers after booking an event #17761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coder-adnan
Copy link

@coder-adnan coder-adnan commented Nov 20, 2024

What does this PR do?

This PR modifies the booking confirmation page to show the "Add to calendar" section for customers after booking an event. This change aims to help prevent no-shows by making it easier for customers to add the event to their calendars.

Mandatory Tasks

  • [yes] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [yes] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

The test performed successful to show the

This PR modifies the booking confirmation page to show the "Add to calendar" section for customers after booking an event. This change aims to help prevent no-shows by making it easier for customers to add the event to their calendars.

Copy link

vercel bot commented Nov 20, 2024

@coder-adnan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 20, 2024
@graphite-app graphite-app bot requested a review from a team November 20, 2024 12:06
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Show 'Add to calendar' section for customers after booking an event - Fixes #17749". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Nov 20, 2024
@coder-adnan
Copy link
Author

This pull request fixes the issue of showing the "Add to calendar" section on the booking confirmation page for non-host users. Previously, this section was only visible to the host, which could lead to customers forgetting to add the event to their calendars and potentially missing the meeting.

The changes made include modifying the condition in the bookings-single-view.tsx file to ensure that the "Add to calendar" section is displayed for customers as well. This will help reduce no-shows by making it easier for customers to add the event to their calendars directly from the confirmation page.

Additionally, test cases in the bookings-single-view.test.tsx file have been updated to cover this new functionality, ensuring that the section is correctly displayed and functional for customers.

This fix addresses GitHub issue #17749.

Copy link

graphite-app bot commented Nov 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/20/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh changed the title Show 'Add to calendar' section for customers after booking an event - Fixes #17749 feat: Show 'Add to calendar' section for customers after booking an event Nov 20, 2024
@@ -202,7 +202,8 @@ export default function Success(props: PageProps) {
};

function setIsCancellationMode(value: boolean) {
const _searchParams = new URLSearchParams(searchParams ?? undefined);
// Convert ReadonlyURLSearchParams to URLSearchParams
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment.

@Praashh
Copy link
Contributor

Praashh commented Nov 20, 2024

Hey @coder-adnan please Sign CLA

@Praashh Praashh changed the title feat: Show 'Add to calendar' section for customers after booking an event feat: Show add to calendar section for customers after booking an event Nov 20, 2024
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @coder-adnan, can you please attach a screen recording of the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "Add to calendar" on booking confirmation page for non-host users
3 participants