fix: correct message and translation key #15657
Conversation
|
|
|
@RushikeshGandhmal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add community label" took an action on this PR • (07/03/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (07/03/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
So here we were using event_type_requres_google_cal which was not present. Correct one is requires_google_calendar. Can we add new message instead ? with link redirecting to google_calendar to install as it requires. |
|
Before: Change it pointing to event types/advanced which has nothing to do with adding google calendar. @PeerRich After: |
There was a problem hiding this comment.
Hey @RushikeshGandhmal, I think the message is correct. We should change the link to redirect to the Google Calendar in the App Store. Also, please add the missing translation in the locales using this key.
And instead of 'change it here,' we should add 'connect Google Calendar.'
RushikeshGandhmal
force-pushed
the
rushikesh_correct_translation_key
branch
from
492264b
to
df9e70c
Compare
|
@anikdhabal that's what I though in the first place and asked the confirmation above. I've pushed the code. The message can we better, to make it easy for user to read and understand @PeerRich @hariombalhara |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seventy-eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
RushikeshGandhmal
force-pushed
the
rushikesh_correct_translation_key
branch
from
8a7e693
to
54be5ae
Compare
| <Link | ||
| href={`${WEBAPP_URL}/event-types/${formMethods.getValues("id")}?tabName=advanced`} | ||
| className="underline"> | ||
| <Link href={`${WEBAPP_URL}/apps/google-calendar`} className="underline"> |
There was a problem hiding this comment.
Why is this link changed?
Also, could you test with a dummy translation for any non-english language that confirms that it works.
There was a problem hiding this comment.
In our code, we check if the conferencing app is Google Meet and the destinationCalendar?.integration !== "google_calendar". If it isn't, we show this message. Previously, the link redirected to the event advanced tab, but this is unrelated.
There was a problem hiding this comment.
Hey @RushikeshGandhmal, it’s not fixed yet. Take the bottom i18nkey in this component as a reference. And please test it before the final commit. Also, instead of 'change it here,' use 'Connect it here.'
|
@anikdhabal please take a look at screenshots before committing. Once confirmed I'll add the sentence in all the required languages. |
|
Great work @RushikeshGandhmal pls commit the changes. |
|
Sure @anikdhabal. Thank you for right direction. Appreciate that. and yes @hariombalhara for any non-english language it works. But as @anikdhabal said we don't need to add to other locals. It's in english only. Let me know, I can add in other languages also. For example here I choose Deutsch. |
hey in our project we handle it externally for other language, you don't need to do extra work. |
|
Sure @anikdhabal. Thanks for informing. |
|
Yeah, no need for non english translation. I meant to test for the translation so that we know it's properly implemented. Sometimes, when key isn't properly specified, english lang still works but other languages don't translate. |
|
@hariombalhara gotcha. Yeah, I've tested working well for all languages. rushikesh. |
anikdhabal
dismissed
hariombalhara’s stale review
I've tested it locally, and it works for other languages as well.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist