fix: multiple getSchedule requests on email change in booker

[dilpreetsio]

What does this PR do?

• Fixes [CAL-3974] Multiple Slots.getSchedule requests being sent when typing email on booker page #15574

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• N/A-I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• Create an event-type
• Create a booking
• Open network tab in dev tools & update the email field.

There are no more requests for slots when the email is changed.

Screen.Recording.2024-06-28.at.7.52.55.PM.mov

[vercel]

@dilpreetsio is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[graphite-app]

Graphite Automations

"Add community label" took an action on this PR • (06/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (06/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[anikdhabal]

Hey, one more request is being sent - checkIfUserEmailVerificationRequired. This is from the useVerifyEmail hook. Do you think it would be optimal to not pass bookerEmail? This bookerEmail retrieves the email address of the owner of a contact in the CRM system.

[dilpreetsio]

@anikdhabal The checkIfUserEmailVerificationRequired is basically checking if the email is blacklisted or not, so we need to keep it.

[nishchal27]

making a server request on every keystroke can be costly

[dilpreetsio]

The input is debounced to reduce the number of request. If we want to further reduce the number of requests one way to go ahead would be check if the email is valid before sending a request.

[dilpreetsio]

Do you think it would be optimal to not pass bookerEmail? This bookerEmail retrieves the email address of the owner of a contact in the CRM system.

Do you mean not passing the bookerEmail to the useScheduleForEvent hook ?

[Udit-takkar]

@dilpreetsio how does this fix the issue?
bookerEmail was required in packages/trpc/server/routers/viewer/slots/util.ts

  const crmContactOwner = await getCRMContactOwnerForRRLeadSkip(
      input.bookerEmail,
      eventType?.metadata?.apps
    );
    

[anikdhabal]

Do you mean not passing the bookerEmail to the useScheduleForEvent hook ?

Yes, @Udit-takkar shared the code above.