feat: Round Robin Weights #15558
Merged
feat: Round Robin Weights #15558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
June 17, 2024 10:31
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
E2E results are ready! |
emrysal
reviewed
Aug 15, 2024
packages/features/eventtypes/components/AddMembersWithSwitch.tsx
Outdated
Show resolved
Hide resolved
emrysal
approved these changes
Aug 15, 2024
| @@ -23,10 +39,11 @@ async function leastRecentlyBookedUser<T extends Pick<User, "id" | "email">>({ | |||
| createdAt: true, | |||
| }, | |||
| where: { | |||
| eventTypeId, | |||
| eventTypeId: eventType.id, | |||
| status: BookingStatus.ACCEPTED, | |||
There was a problem hiding this comment.
Sounds sensible! Yeah happy with that.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds weights to round robin alogirthm. When weights are enabled each host has 100% as the default weight. That means that ideally, all hosts end up with the same amount of bookings. If weights are enabled, priorities are only taken into account when more than one host is selected by the
getUsersBasedOnWeightsfunction.To make sure that adding new host, when other hosts already have bookings doesn't result in the new host being assigned to all bookings we use weightAdjustments.
WeightAdjustment (nr of 'fake' bookings)= ((nr of all bookings of current RR hosts+sum of all weight adjustments of current RR hosts) /sum of all current RR hosts weights) *new host's weightWeights enabled:
Weights disabled:
Set weight:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?