Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cache timezones by calcom version #15556

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

keithwillcode
Copy link
Contributor

After reviewing our bandwidth usage, I see we are not caching timezones aggressively enough. Considering they rarely change and we can use a similar mechanism to what we did with i18n where we cache by calcom version, decided to implement for this as well.

@keithwillcode keithwillcode added the Medium priority Created by Linear-GitHub Sync label Jun 24, 2024
@keithwillcode keithwillcode added this to the v4.4 milestone Jun 24, 2024
@keithwillcode keithwillcode self-assigned this Jun 24, 2024
@graphite-app graphite-app bot requested a review from a team June 24, 2024 21:51
@keithwillcode keithwillcode added core area: core, team members only foundation ready-for-e2e labels Jun 24, 2024
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 10:12pm
cal ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 10:12pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 10:12pm

Copy link

graphite-app bot commented Jun 24, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (06/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 593.33 KB 821.03 KB 234.58% (🟡 +0.20%)
/auth/saml-idp 12.22 KB 239.92 KB 68.55% (🟢 -20.80%)
/event-types 566.36 KB 794.06 KB 226.87% (🟡 +0.29%)
/settings/admin/lockedSMS/UsersTable 79.88 KB 307.58 KB 87.88% (🟢 -0.17%)
/settings/admin/lockedSMS/lockedSMSView 119.37 KB 347.06 KB 99.16% (🟢 -0.20%)
/settings/admin/oAuth/oAuthView 95.43 KB 323.13 KB 92.32% (🟢 -0.19%)
/settings/organizations/[id]/about 159.59 KB 387.29 KB 110.65% (🟡 +0.46%)
/settings/organizations/[id]/add-teams 159.58 KB 387.28 KB 110.65% (🟡 +0.45%)
/settings/organizations/new 159.6 KB 387.29 KB 110.66% (🟡 +0.45%)
/settings/platform/new 120.65 KB 348.34 KB 99.53% (🟡 +0.50%)
/video/[uid] 290.75 KB 518.44 KB 148.13% (🟢 -0.31%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@dosubot dosubot bot added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Jun 24, 2024
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@keithwillcode keithwillcode added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2024
@keithwillcode keithwillcode added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2024
@keithwillcode keithwillcode added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit e33930e Jun 26, 2024
33 of 38 checks passed
@keithwillcode keithwillcode deleted the chore/cache-timezones branch June 26, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only foundation Medium priority Created by Linear-GitHub Sync performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants