feat: add instant meeting expiry input #15555

Udit-takkar · 2024-06-24T20:28:07Z

What does this PR do?

Fixes [CAL-3951] Add input to change instant meeting duration #15499
Fixes CAL-3951 (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected)
N/A I have added a Docs issue here if this PR makes changes that would require a documentation change
N/A I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Go to an org team event type settings
Select Instant bookings
Turn on Instant Booking toggle
Update the expiry time offset

linear · 2024-06-24T20:28:09Z

CAL-3951 Add input to change instant meeting duration

vercel · 2024-06-25T07:44:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 10:48am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jun 26, 2024 10:48am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Jun 26, 2024 10:48am

github-actions · 2024-06-25T07:57:33Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/apps/[slug]/[...pages]`	`593.33 KB`	821.03 KB	234.58% (🟡 +0.20%)
`/auth/saml-idp`	`12.22 KB`	239.92 KB	68.55% (🟢 -20.80%)
`/event-types`	`566.36 KB`	794.06 KB	226.87% (🟡 +0.29%)
`/event-types/[type]`	`442.02 KB`	669.71 KB	191.35% (🟡 +0.14%)
`/settings/admin/lockedSMS/UsersTable`	`79.91 KB`	307.61 KB	87.89% (🟢 -0.16%)
`/settings/admin/lockedSMS/lockedSMSView`	`119.39 KB`	347.09 KB	99.17% (🟢 -0.19%)
`/settings/admin/oAuth/oAuthView`	`95.44 KB`	323.14 KB	92.33% (🟢 -0.19%)
`/settings/organizations/[id]/about`	`159.6 KB`	387.3 KB	110.66% (🟡 +0.45%)
`/settings/organizations/[id]/add-teams`	`159.59 KB`	387.29 KB	110.65% (🟡 +0.46%)
`/settings/organizations/new`	`159.6 KB`	387.3 KB	110.66% (🟡 +0.45%)
`/settings/platform/new`	`120.65 KB`	348.34 KB	99.53% (🟡 +0.50%)
`/video/[uid]`	`290.75 KB`	518.44 KB	148.13% (🟢 -0.31%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

graphite-app · 2024-06-25T08:10:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

apps/web/public/static/locales/en/common.json

PeerRich · 2024-06-25T14:51:06Z

looks good

easy addition

zomars · 2024-06-26T08:38:10Z

packages/prisma/schema.prisma

@@ -133,6 +133,7 @@ model EventType {
  /// @zod.custom(imports.intervalLimitsType)
  durationLimits                       Json?
  isInstantEvent                       Boolean                   @default(false)
+  instantMeetingExpiryTimeOffset       Int                       @default(90)


Nitpick here. Are these seconds? minutes? Can we specify in the column name? I know it's already quite long enough. instantMeetingExpiryTimeOffsetInSeconds

* feat: add instant meeting expiry input * fix: type err * chore: remove type * chore: update label * chore: update column name

feat: add instant meeting expiry input

1bc53b5

github-actions bot added High priority Created by Linear-GitHub Sync ✨ feature New feature or request ❗️ migrations contains migration files and removed ✨ feature New feature or request High priority Created by Linear-GitHub Sync labels Jun 24, 2024

keithwillcode added consumer core area: core, team members only labels Jun 24, 2024

vercel bot had a problem deploying to Preview – api June 24, 2024 20:28 Failure

vercel bot deployed to Preview – dev June 24, 2024 20:40 View deployment

PeerRich previously approved these changes Jun 24, 2024

View reviewed changes

github-actions bot added the ready-for-e2e label Jun 24, 2024

fix: type err

98283b1

Udit-takkar dismissed PeerRich’s stale review via 98283b1 June 25, 2024 07:44

github-actions bot added High priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Jun 25, 2024

vercel bot had a problem deploying to Preview – api June 25, 2024 07:48 Failure

chore: remove type

ccfd80c

Udit-takkar marked this pull request as ready for review June 25, 2024 08:07

graphite-app bot requested a review from a team June 25, 2024 08:07

vercel bot deployed to Preview – api June 25, 2024 08:07 View deployment

dosubot bot added this to the v4.3 milestone Jun 25, 2024

vercel bot deployed to Preview – dev June 25, 2024 08:20 View deployment

PeerRich reviewed Jun 25, 2024

View reviewed changes

apps/web/public/static/locales/en/common.json Outdated Show resolved Hide resolved

chore: update label

01dbc20

Udit-takkar requested a review from PeerRich June 25, 2024 13:03

vercel bot deployed to Preview – api June 25, 2024 13:09 View deployment

vercel bot deployed to Preview – dev June 25, 2024 13:18 View deployment

PeerRich previously approved these changes Jun 25, 2024

View reviewed changes

Merge branch 'main' into feat/instant-meeting-offset

1145fc9

vercel bot deployed to Preview – api June 25, 2024 15:01 View deployment

vercel bot deployed to Preview – dev June 25, 2024 15:10 View deployment

Merge branch 'main' into feat/instant-meeting-offset

620a396

vercel bot deployed to Preview – api June 26, 2024 05:37 View deployment

vercel bot deployed to Preview – dev June 26, 2024 05:47 View deployment

PeerRich added this pull request to the merge queue Jun 26, 2024

zomars reviewed Jun 26, 2024

View reviewed changes

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024

chore: update column name

3978a51

Udit-takkar dismissed PeerRich’s stale review via 3978a51 June 26, 2024 10:43

vercel bot deployed to Preview – ai June 26, 2024 10:48 View deployment

Udit-takkar requested a review from zomars June 26, 2024 10:49

vercel bot deployed to Preview – api June 26, 2024 10:53 View deployment

vercel bot deployed to Preview – dev June 26, 2024 11:12 View deployment

zomars approved these changes Jun 26, 2024

View reviewed changes

keithwillcode added this pull request to the merge queue Jun 26, 2024

Merged via the queue into main with commit d25595b Jun 26, 2024
32 of 38 checks passed

keithwillcode deleted the feat/instant-meeting-offset branch June 26, 2024 15:00

p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024

feat: add instant meeting expiry input (calcom#15555)

d8834ea

* feat: add instant meeting expiry input * fix: type err * chore: remove type * chore: update label * chore: update column name

p6l-richard mentioned this pull request Jul 24, 2024

fix(marketing): move the sitemap for search engines to core app #15893

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add instant meeting expiry input #15555

feat: add instant meeting expiry input #15555

Udit-takkar commented Jun 24, 2024 •

edited

Loading

linear bot commented Jun 24, 2024

vercel bot commented Jun 25, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading

graphite-app bot commented Jun 25, 2024

PeerRich commented Jun 25, 2024

zomars Jun 26, 2024

Udit-takkar Jun 26, 2024

feat: add instant meeting expiry input #15555

feat: add instant meeting expiry input #15555

Conversation

Udit-takkar commented Jun 24, 2024 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

linear bot commented Jun 24, 2024

vercel bot commented Jun 25, 2024 • edited Loading

github-actions bot commented Jun 25, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

Twelve Pages Changed Size

graphite-app bot commented Jun 25, 2024

Graphite Automations

PeerRich commented Jun 25, 2024

zomars Jun 26, 2024

Choose a reason for hiding this comment

Udit-takkar Jun 26, 2024

Choose a reason for hiding this comment

Udit-takkar commented Jun 24, 2024 •

edited

Loading

vercel bot commented Jun 25, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading