-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add date overrides to availability settings atom #15459
feat: add date overrides to availability settings atom #15459
Conversation
Rajiv Sahal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…ility-settings-atom
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
</div> | ||
) : ( | ||
<></> | ||
{enableOverrides && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enableOverrides
prop allows users to enable or disable date overrides inside an atom
date: `${range.start.getUTCFullYear}-${range.start.getUTCMonth}-${range.start.getUTCDate}`, | ||
startTime: `${range.start.getUTCHours}-${range.start.getUTCMinutes}`, | ||
endTime: `${range.end.getUTCHours}-${range.end.getUTCMinutes}`, | ||
date: `${range.start.getUTCFullYear()}-${range.start.getUTCMonth()}-${range.start.getUTCDate()}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While transforming the overrides data into data suitable for v2 api inside of the function transformAtomScheduleForApi
none of the functions were being invoked and this was causing the requests to fail with an internal server error.
…ility-settings-atom
Graphite Automations"Add platform team as reviewer" took an action on this PR • (06/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There were problems when overrides were being formatted for API:
In commit fix: date overrides formatting for api request I fixed it. Before![]() After![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With fix above can confirm that it's possible to create date override and that it is reflected during booker's available times.
…ility-settings-atom
* remove console.log * fixup: logic to convert overrides was not calling functions * refactor handleSubmit function * add portal to platform dialog component * cleanup * add props to enable and disable date overrides * show date overrides for availability settings atom * fix: date overrides formatting for api request --------- Co-authored-by: Rajiv Sahal <[email protected]> Co-authored-by: supalarry <[email protected]> Co-authored-by: Morgan <[email protected]>
What does this PR do?
Availability Settings
atom, this was previously not possible in v2 because of how the schedules api was structured. With the recent schedules refactor we now have date overrides for atoms as well.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This can be tested in the platform examples app