Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar height being fixed for platform dashboard #15223

Merged
merged 3 commits into from
Jun 7, 2024
Merged

fix: sidebar height being fixed for platform dashboard #15223

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae6442d
fix sidebar height not growing
May 28, 2024
6cbbfdf
Merge branch 'main' into fix-sidebar-height
Ryukemeister May 28, 2024
bafcecc
Merge branch 'main' into fix-sidebar-height
ThyMinimalDev May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/features/shell/Shell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,10 @@ function SideBar({ bannersHeight, user, isPlatformUser = false }: SideBarProps)
<div className="relative">
<aside
style={!isPlatformUser ? sidebarStylingAttributes : {}}
className="bg-muted border-muted fixed left-0 hidden h-full max-h-screen w-14 flex-col overflow-y-auto overflow-x-hidden border-r md:sticky md:flex lg:w-56 lg:px-3">
className={classNames(
"bg-muted border-muted fixed left-0 hidden h-full w-14 flex-col overflow-y-auto overflow-x-hidden border-r md:sticky md:flex lg:w-56 lg:px-3",
!isPlatformUser && "max-h-screen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Shell should not be aware of isPlatformUser, we should refactor to pass props directly to style as needed

)}>
<div className="flex h-full flex-col justify-between py-3 lg:pt-4">
<header className="todesktop:-mt-3 todesktop:flex-col-reverse todesktop:[-webkit-app-region:drag] items-center justify-between md:hidden lg:flex">
{orgBranding ? (
Expand Down
Loading