Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Profile page crash due to invalid topLevelElement #15198

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: Profile page crash due to invalid topLevelElement #15198

merged 1 commit into from
May 24, 2024

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented May 24, 2024

What does this PR do?

Fixes that adding unterminated nodes like
can crash the profile page.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@CarinaWolli are there tests to cover the Editor?

@emrysal emrysal requested a review from CarinaWolli May 24, 2024 15:12
@linear Linear
Copy link

linear bot commented May 24, 2024

CAL-3804 Adding unterminated nodes like <br> can crash the profile page.

@graphite-app graphite-app bot requested a review from a team May 24, 2024 15:12
@github-actions GitHub Actions
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels May 24, 2024
@keithwillcode keithwillcode added core area: core, team members only foundation labels May 24, 2024
@vercel Vercel
Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 3:13pm

@CarinaWolli CarinaWolli mentioned this pull request May 24, 2024
Closed
@graphite-app Graphite App
Copy link

graphite-app bot commented May 24, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (05/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@CarinaWolli
Copy link
Member

@CarinaWolli are there tests to cover the Editor?

No tests, I created an issue: #15199

@CarinaWolli CarinaWolli added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@keithwillcode keithwillcode added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@emrysal emrysal added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 5d32549 May 24, 2024
23 checks passed
@emrysal emrysal deleted the bugfix/3804-fix-bio-profile-page-crash branch May 24, 2024 16:28
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
@emrysal @p6l-richard
fix: Profile page crash due to invalid topLevelElement (calcom#15198)
e2d1060
@p6l-richard p6l-richard mentioned this pull request Jul 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working core area: core, team members only foundation ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-3804] Adding unterminated nodes like <br> can crash the profile page.
3 participants
@emrysal @CarinaWolli @keithwillcode