Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis cache key overlap #14938

Merged
merged 2 commits into from
May 8, 2024
Merged

fix: redis cache key overlap #14938

merged 2 commits into from
May 8, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

What does this PR do?

Fixes redis error WRONGTYPE Operation against a key holding the wrong kind of value caused by the fact that the same key is set with both hset (hash) and setex (key/value), this key is then fetched using hgetall which expect a hash, not a key/value pair

solving the issue by having 2 different keys

@graphite-app graphite-app bot requested a review from a team May 8, 2024 10:16
@ThyMinimalDev ThyMinimalDev requested review from keithwillcode and removed request for a team May 8, 2024 10:16
Copy link
Contributor

github-actions bot commented May 8, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels May 8, 2024
@graphite-app graphite-app bot requested a review from a team May 8, 2024 10:17
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels May 8, 2024
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 10:18am
cal ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 10:18am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 10:18am

Copy link

graphite-app bot commented May 8, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (05/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (05/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode enabled auto-merge (squash) May 8, 2024 10:21
Copy link
Contributor

github-actions bot commented May 8, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented May 8, 2024

Current Playwright Test Results Summary

✅ 3 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/08/2024 10:40:37am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 184d1bd

Started: 05/08/2024 10:40:18am UTC

⚠️ Flakes

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1Initial Attempt
18.75% (63) 63 / 336 runs
failed over last 7 days
37.80% (127) 127 / 336 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode merged commit 5d7b2a1 into main May 8, 2024
41 checks passed
@keithwillcode keithwillcode deleted the fix-redis-key-conflict branch May 8, 2024 10:41
keithwillcode pushed a commit that referenced this pull request May 8, 2024
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants