fix: Impersonation flicker on timezone change #14738
Conversation
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/24/24)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
automated-tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 314 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/24/2024 09:14:07pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: af3dcc1 Started: 04/24/2024 09:10:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2 • Retry 1 • Initial Attempt |
5.69% (16)16 / 281 runsfailed over last 7 days |
33.45% (94)94 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
17.54% (47)47 / 268 runsfailed over last 7 days |
6.34% (17)17 / 268 runsflaked over last 7 days |
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0.45% (1)1 / 222 runfailed over last 7 days |
27.93% (62)62 / 222 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity it can delete date overrides
Retry 1 • Initial Attempt |
0% (0)0 / 274 runsfailed over last 7 days |
1.46% (4)4 / 274 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 272 runsfailed over last 7 days |
43.75% (119)119 / 272 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
17.10% (46)46 / 269 runsfailed over last 7 days |
52.04% (140)140 / 269 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-168.67% (-140)-140 / 83 runsfailed over last 7 days |
168.67% (140)140 / 83 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-167.47% (-139)-139 / 83 runsfailed over last 7 days |
167.47% (139)139 / 83 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-166.27% (-138)-138 / 83 runsfailed over last 7 days |
167.47% (139)139 / 83 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-169.51% (-139)-139 / 82 runsfailed over last 7 days |
169.51% (139)139 / 82 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-169.51% (-139)-139 / 82 runsfailed over last 7 days |
169.51% (139)139 / 82 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-169.51% (-139)-139 / 82 runsfailed over last 7 days |
169.51% (139)139 / 82 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-169.51% (-139)-139 / 82 runsfailed over last 7 days |
169.51% (139)139 / 82 runsflaked over last 7 days |
What does this PR do?
IS_VISUAL_REGRESSION_TESTING- instead we set a global cookie that disables the timezone change popup. It is possible to remove this cookie to confirm the timezone change works properly (but maybe best tested with vitest and not e2e).