test: add unit tests for sms sending #14737

CarinaWolli · 2024-04-24T19:28:45Z

What does this PR do?

Adds units tests for SMS sending when an event type with an active SMS workflow is booked. Also tests that SMS are not sent if user or team is locked for SMS sending.

Run yarn test workflow-notifications.test.ts

Fixes #14726

github-actions · 2024-04-24T19:28:56Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

vercel · 2024-04-24T19:30:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2024 1:32pm
platform-starter-kit	❌ Failed (Inspect)			May 2, 2024 1:32pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 2, 2024 1:32pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 2, 2024 1:32pm

github-actions · 2024-04-24T19:42:44Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-04-24T19:43:26Z

Current Playwright Test Results Summary

✅ 315 Passing - ⚠️ 18 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/02/2024 01:48:08pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 4a1a1df

Started: 05/02/2024 01:42:59pm UTC

⚠️ Flakes

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default Retry 1 • Initial Attempt	0.82% (2) 2 / 244 runs failed over last 7 days	21.31% (52) 52 / 244 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it Retry 1 • Initial Attempt	0% (0) 0 / 262 runs failed over last 7 days	10.31% (27) 27 / 262 runs flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved Retry 1 • Initial Attempt	2.21% (5) 5 / 226 runs failed over last 7 days	15.04% (34) 34 / 226 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
BOOKING_RESCHEDULED when rescheduling to a booking that already exists, should send a booking rescheduled event with the existant booking uid Retry 2 • Retry 1 • Initial Attempt	10.27% (23) 23 / 224 runs failed over last 7 days	46.88% (105) 105 / 224 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Preview Preview - embed-core should load Retry 1 • Initial Attempt	0% (0) 0 / 243 runs failed over last 7 days	44.86% (109) 109 / 243 runs flaked over last 7 days

📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats Retry 1 • Initial Attempt	0% (0) 0 / 217 runs failed over last 7 days	5.99% (13) 13 / 217 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

`null`	9 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	14.01% (36) 36 / 257 runs failed over last 7 days	48.64% (125) 125 / 257 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-130.21% (-125) -125 / 96 runs failed over last 7 days	130.21% (125) 125 / 96 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-131.58% (-125) -125 / 95 runs failed over last 7 days	131.58% (125) 125 / 95 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-129.47% (-123) -123 / 95 runs failed over last 7 days	129.47% (123) 123 / 95 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-129.47% (-123) -123 / 95 runs failed over last 7 days	129.47% (123) 123 / 95 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-129.47% (-123) -123 / 95 runs failed over last 7 days	129.47% (123) 123 / 95 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-129.47% (-123) -123 / 95 runs failed over last 7 days	129.47% (123) 123 / 95 runs flaked over last 7 days
Popup Tests should open on clicking child element Retry 1 • Initial Attempt	-132.86% (-93) -93 / 70 runs failed over last 7 days	132.86% (93) 93 / 70 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-129.47% (-123) -123 / 95 runs failed over last 7 days	129.47% (123) 123 / 95 runs flaked over last 7 days

📄 apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Round Robin EventType Retry 1 • Initial Attempt	17.80% (47) 47 / 264 runs failed over last 7 days	22.35% (59) 59 / 264 runs flaked over last 7 days

📄 apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 1 • Initial Attempt	7.84% (20) 20 / 255 runs failed over last 7 days	34.51% (88) 88 / 255 runs flaked over last 7 days

📄 apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Newly added secondary email should show as Unverified Retry 1 • Initial Attempt	0.43% (1) 1 / 232 run failed over last 7 days	9.48% (22) 22 / 232 runs flaked over last 7 days

View Detailed Build Results

graphite-app · 2024-04-25T01:35:12Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

joeauyeung

Heads up I'm seeing two errors popping up for tests

Udit-takkar

LGTM. worked fine for me

CarinaWolli · 2024-04-26T15:56:00Z

@joeauyeung did you run migrations?

hariombalhara

Nice work @CarinaWolli !!

looks like migration were not ran

* add tests for workflow sms * fix type error * improvements * add tests for team workflow * rename test * add emailsToReceive everywhere * fix type errors * code clean up * fix fresh-booking.test.ts * add destination email to emailsToReceive * remove unused webhooks --------- Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Hariom <[email protected]>

add tests for workflow sms

dbba2b8

github-actions bot added the automated-tests area: unit tests, e2e tests, playwright label Apr 24, 2024

keithwillcode added consumer core area: core, team members only labels Apr 24, 2024

fix type error

49b173e

vercel bot had a problem deploying to Preview – platform-starter-kit April 24, 2024 19:33 Failure

vercel bot had a problem deploying to Preview – api April 24, 2024 19:34 Failure

improvements

32d5a33

vercel bot had a problem deploying to Preview – platform-starter-kit April 24, 2024 19:48 Failure

vercel bot deployed to Preview – api April 24, 2024 19:55 View deployment

vercel bot deployed to Preview – dev April 24, 2024 20:20 View deployment

add tests for team workflow

1b4b210

vercel bot had a problem deploying to Preview – platform-starter-kit April 24, 2024 23:57 Failure

github-actions bot added the High priority Created by Linear-GitHub Sync label Apr 24, 2024

rename test

5652c9b

vercel bot deployed to Preview – api April 25, 2024 00:02 View deployment

add emailsToReceive everywhere

1200687

vercel bot had a problem deploying to Preview – platform-starter-kit April 25, 2024 00:03 Failure

fix type errors

f03e58e

vercel bot deployed to Preview – api April 25, 2024 00:08 View deployment

vercel bot had a problem deploying to Preview – platform-starter-kit April 25, 2024 00:09 Failure

vercel bot deployed to Preview – api April 25, 2024 00:14 View deployment

code clean up

d55a745

vercel bot deployed to Preview – dev April 25, 2024 00:33 View deployment

fix fresh-booking.test.ts

0023086

vercel bot had a problem deploying to Preview – platform-starter-kit April 25, 2024 00:38 Failure

vercel bot had a problem deploying to Preview – platform-starter-kit April 25, 2024 01:31 Failure

dosubot bot added bookings area: bookings, availability, timezones, double booking workflows area: workflows, automations labels Apr 25, 2024

vercel bot deployed to Preview – api April 25, 2024 01:37 View deployment

vercel bot deployed to Preview – dev April 25, 2024 01:49 View deployment

Merge branch 'main' into tests/sms-locking

130be41

vercel bot had a problem deploying to Preview – platform-starter-kit April 25, 2024 13:15 Failure

vercel bot deployed to Preview – api April 25, 2024 13:21 View deployment

vercel bot deployed to Preview – dev April 25, 2024 13:33 View deployment

Merge branch 'main' into tests/sms-locking

649146d

vercel bot had a problem deploying to Preview – platform-starter-kit April 26, 2024 14:36 Failure

vercel bot deployed to Preview – ai April 26, 2024 14:39 View deployment

vercel bot deployed to Preview – api April 26, 2024 14:43 View deployment

joeauyeung previously requested changes Apr 26, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – dev April 26, 2024 14:48 Failure

Udit-takkar reviewed Apr 26, 2024

View reviewed changes

Udit-takkar requested a review from joeauyeung April 29, 2024 08:35

Merge remote-tracking branch 'origin/main' into tests/sms-locking

4a1a1df

hariombalhara approved these changes May 2, 2024

View reviewed changes

hariombalhara enabled auto-merge (squash) May 2, 2024 13:30

vercel bot deployed to Preview – ai May 2, 2024 13:32 View deployment

vercel bot deployed to Preview – api May 2, 2024 13:35 View deployment

vercel bot had a problem deploying to Preview – dev May 2, 2024 13:40 Failure

hariombalhara merged commit 0391bfe into main May 2, 2024
39 of 40 checks passed

hariombalhara deleted the tests/sms-locking branch May 2, 2024 14:42

p6l-richard mentioned this pull request Jul 24, 2024

fix(marketing): move the sitemap for search engines to core app #15893

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add unit tests for sms sending #14737

test: add unit tests for sms sending #14737

CarinaWolli commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

vercel bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

deploysentinel bot commented Apr 24, 2024 •

edited

Loading

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

graphite-app bot commented Apr 25, 2024

joeauyeung left a comment

Udit-takkar left a comment •

edited

Loading

CarinaWolli commented Apr 26, 2024

hariombalhara left a comment

test: add unit tests for sms sending #14737

test: add unit tests for sms sending #14737

Conversation

CarinaWolli commented Apr 24, 2024 • edited Loading

What does this PR do?

github-actions bot commented Apr 24, 2024 • edited Loading

vercel bot commented Apr 24, 2024 • edited Loading

github-actions bot commented Apr 24, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Apr 24, 2024 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

graphite-app bot commented Apr 25, 2024

Graphite Automations

joeauyeung left a comment

Choose a reason for hiding this comment

Udit-takkar left a comment • edited Loading

Choose a reason for hiding this comment

CarinaWolli commented Apr 26, 2024

hariombalhara left a comment

Choose a reason for hiding this comment

CarinaWolli commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

vercel bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024 •

edited

Loading

deploysentinel bot commented Apr 24, 2024 •

edited

Loading

Udit-takkar left a comment •

edited

Loading