Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Conversation

@Mdrbhatti
Copy link
Contributor

@LegNeato
Copy link
Contributor

Thank you for the patch! The test failure looks legit?

@LegNeato
Copy link
Contributor

It looks like aws/aws-lambda-go@b4388e4#diff-862417b9e7c3720bcb3263cd873b09892d787823b6f9a0f453e42824c5a4d4b6 might have introduced the breaking change, via this PR:

aws/aws-lambda-go#385

@LegNeato
Copy link
Contributor

Filed aws/aws-lambda-go#390.

@LegNeato
Copy link
Contributor

You'll also want to update https://github.com/LegNeato/aws-lambda-events/blob/master/aws_lambda_events_codegen/src/main.rs#L143 as the test event has been renamed in the latest go sdk (in aws/aws-lambda-go@ee817dd)

@LegNeato
Copy link
Contributor

Great. Looks like there is a PR to fix the issue on the go side. Once that lands can you regenerate this to get the tests to pass? After I'll cut a release.

Thank you again for the PR! 🍻

@Mdrbhatti
Copy link
Contributor Author

@LegNeato aws/aws-lambda-go#392 just got merged, so I have now regenerated the code. Tests seem to pass as well!

@LegNeato LegNeato merged commit c3a3861 into calavera:master Sep 18, 2021
@LegNeato
Copy link
Contributor

Awesome, thank you! I'll do a crates.io release tomorrow.

@LegNeato
Copy link
Contributor

This has now been released to crates.io, sorry for the delay! 🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AlbTargetGroupRequest misses default value for headers

2 participants