-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Public interface for TCC.db #391
Conversation
@TobiasRoikjer Please review. It is a big PR, but a complete feature. I am most interested in feedback about the public API: 1c8015e This is a reimplementation of calabash-ios/launcher.rb TCC code |
@krukow Can you review? I would like to release this so it can be available in Calabash 0.18.2. |
Moving out of the feature set for 0.18.2. |
This feature will not be merged because we have no way of performing the same operation on physical devices. |
This feature is pretty cool. Is there no place for simulator only features in calabash? I ended up forking run_loop and restoring TCC.db support. |
@bootstraponline I agree that this is a cool feature. I am trying to find support for merging it. |
1c8015e
to
96e5dde
Compare
REBASED Mon Aug 29 19:54 CET Reviving. At the very least, I want this as gem maintainer. |
I also approve this feature. Testing on the simulator is way easier with TCC.db modifications. I made two changes from upstream:
If the revival is successful, it'd be nice to have a way to get these improvements into upstream. |
Yeah. I am probably going add an I saw the keyboard settings, but I am not sure I understand the value. I can be convinced. I noticed you were using CFPropertyList (IIRC). We are trying to remove that gem from the stack. It has (at least in the past) not written BOOL type values correctly. |
Ouch. I'll migrate over to whatever the replacement ends up being then.
What do you think about allowing users to specify their own keyboard settings? Right now it looks like there's just a hard coded set of options. I'm trying to match the Facebook configuration so the existing default doesn't work for me.
Cool. |
Huh. Already exists. Just pass an empty array or no array at all. I will have to check the command line interface.
We shell out to /usr/libexec/PlistBuddy. :/
I will look at what you have again. Probably no changes until after the iOS 10 dust settles. |
I think you're misunderstanding the code. The bundle id changes allow configuring apps that don't exist (meaning there is no .app path, only a bundle id). |
I want to support |
Agreed. :) On Mon, Aug 29, 2016, 6:49 PM Joshua Moody [email protected] wrote:
|
Someday I will get this feature in run_loop calabash/run_loop#391
Does this approach work for location and push permissions? |
It does not work for location or APNS permissions. |
any update on this? 😄 |
It does not work for location or APNS permissions. I also figured out how to get notification permission, you just copy over |
I'm guessing that since calabash is EOL, run_loop won't be getting any new features? |
That is a safe assumption. I could not get traction for this feature because it only worked on simulators. |
REBASED Mon Aug 29 19:54 CET
WIP Based on my work with Permissions TCC, this needs some TLC before merging.
Motivation
Progress on Setting the simulator privacy settings is broken in Xcode 6 #525
Public API