Fix :preferences strategy for iOS 9 #267
Conversation
Who can remember what != NSOrderedAscending means?
When iOS Simulator and iOS >= 9.0, use: `deviceRequestExecutionOf` because it interacts directly with NSUserDefaults API
This is a singleton class, there is no reason for it not be arc.
No need to use dispatch_once here, we can just make this a lazy eval'ed property.
|
Does this mean there will be a pre release with these fixes, so we can try the preferences strategy? We have started the progress of upgrading to SDK 9 (and latest Calabash version), and can now run our "migrate-branch" on an isolated Xcode7/SDK9 buildnode. On the first couple of runs, I have noticed a significant increase in time - will the preferences strategy help with that? And should we overall expect slower tests, as the simulator seems a bit slow in starting 😟 |
:preferences is faster than :host.
iOS 9 Simulators have "booting" state. If we try to install/uninstall or launch an app with instruments, we will get failures. In the recent releases of run-loop, we've been waiting for a stable simulator state. I think I can relax the stable state heuristics in the next version of run-loop. |
I think we will just cut a release next week and keep the default strategy as :host. Savvy users can opt-in to :preferences. |
…y-for-iOS9 Fix :preferences strategy for iOS 9
Motivation
Xcode 7: preferences strategy is not working for iOS >= 9.0 simulators #236
The gist of this pull request is to branch on iOS 9 and interact directly with NSUserDefaults rather than do IO directly on the simulator plist.
Could not reproduce the timing issue #585 with this JaniJegoroff/calabash-ios-example-issue-585#2
Progress on:
As mentioned by @krukow in this issue we should release to allow users like @JaniJegoroff, @ark-konopacki, @nfrydenholm to test.
The contents of https://github.com/xamarin/test-cloud-frontend/issues/1710 should be public - the discussion there is extremely interesting and it is a drag to keep referencing it.